Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(storage): add metrics for uploader memory and no instance id in imm #17104

Merged
merged 5 commits into from
Jun 5, 2024

Conversation

wenym1
Copy link
Contributor

@wenym1 wenym1 commented Jun 4, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Previously, we track the total memory usage of all imm. However, some imm may have already been flushed into sst, but still held by some ongoing iter, which means the current total imm usage is the combination of uploader imms and some orphan imms. In this PR, we introduce a new metrics that only track the total imm usage of uploader imm. We add grafana panel to see the total size of unflushed imm and orphan imm.

In uploader, imm are wrapped by ImmUploader struct, which does not implement Clone to ensure that each imm only exist in place in uploader. When ImmUploader is constructed, it will increment the uploader imm total size, and on Drop, it will decrement the size.

We won't store the instance id in imm any more, because in all usages, we can explicitly know the instance id that an imm belongs to.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@wenym1 wenym1 requested review from hzxa21 and Li0k June 5, 2024 04:16
Copy link
Collaborator

@hzxa21 hzxa21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenym1 wenym1 enabled auto-merge June 5, 2024 06:08
@wenym1 wenym1 added this pull request to the merge queue Jun 5, 2024
Merged via the queue into main with commit e905000 Jun 5, 2024
30 of 31 checks passed
@wenym1 wenym1 deleted the yiming/imm-no-instance-id branch June 5, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants